Change LICENSE.rst to correct license#28
Closed
cadenmyers13 wants to merge 3 commits into
Closed
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #28 +/- ##
===========================================
- Coverage 75.67% 50.00% -25.68%
===========================================
Files 3 2 -1
Lines 37 18 -19
===========================================
- Hits 28 9 -19
Misses 9 9 🚀 New features to boost your workflow:
|
Contributor
Author
|
I also deleted the placeholder code made by skpkg |
sbillinge
reviewed
Aug 6, 2025
sbillinge
left a comment
sbillinge
left a comment
Contributor
There was a problem hiding this comment.
actually, we want to go with the BSD 3-clause here. Let's not go with some horrible legacy license. The original license looks fine so I will just close this PR
Contributor
|
closed as not needed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I got this license from here: https://www.diffpy.org/products/diffpycmi/license.html
I updated the columbia copyright year to 2025, but please make sure this is okay.